fix(complete): Fix zsh handling of multiple arguments #4278
+129
−122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In zsh completion rules, the
*
denotes whether a flag/argument is allowed multiple times or not. However, in clap 4.0.0, all flag/option rules are always marked with*
even if it makes no sense to supply them multiple times, such as--help
.This regressed for flags/options in 6f03b4f, the logic for handling non-multiple arguments with zsh was simply thrown out. While the consequences of this are minor, it's discouraging to see logic discarded without an understanding of why it's there.
The printing of positional multiple args was also tweaked,
ValueRange::new(0..=1)
should not be treated as multiple values.