Include groups in get_arg_conflicts_with
#3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
commented
Jul 9, 2022
tmccombs
force-pushed
the
get-conflicts-with-group
branch
2 times, most recently
from
66cd439
to
dab32a3
Compare
epage
reviewed
Jul 11, 2022
|
Thanks for doing this! |
tmccombs
force-pushed
the
get-conflicts-with-group
branch
from
dab32a3
to
6a11d61
Compare
|
@tmccombs could you run cargo fmt so CI passes? |
So that it doesn't panic if trying to get the conflicts for an Arg that conflicts with a group. Fixes: clap-rs#3900
tmccombs
force-pushed
the
get-conflicts-with-group
branch
from
6a11d61
to
f27f1f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it doesn't panic if trying to get the conflicts for an Arg that
conflicts with a group.
Fixes: #3900