Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put once_cell reexport into __macro_refs #3870

Merged
merged 1 commit into from Jun 28, 2022
Merged

Conversation

stepancheg
Copy link
Contributor

When upgrading our company projects from clap 3.1 to clap 3.2 I had
to fix several references to clap::lazy_init. People are not
supposed to do that, but that's hard to enforce.

Hope placing once_cell reexport into __macro_refs prevent at
least some of the such issues in the future.

@stepancheg
Copy link
Contributor Author

CI failure seems to be unrelated to my PR:
Screenshot 2022-06-26 at 02 03 46

@epage
Copy link
Member

epage commented Jun 26, 2022

CI failure seems to be unrelated to my PR:

The compiler's error messages are deterministic (same from run to run) but seem to be sensitive to small changes in what items get exposed. Feel free to just run the tests with TRYBUILD=overwrite to update the snapshots.

When upgrading our company projects from clap 3.1 to clap 3.2 I had
to fix several references to `clap::lazy_init`. People are not
supposed to do that, but that's hard to enforce.

Hope placing `once_cell` reexport into `__macro_refs` prevent at
least some of the such issues in the future.
@stepancheg
Copy link
Contributor Author

Seems like also specific compiler version is needed. I patched the file manually, hope CI will like it.

@epage
Copy link
Member

epage commented Jun 28, 2022

Thanks!

@epage epage merged commit a05f4d3 into clap-rs:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants