Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ArgMatches::get_raw #3809

Open
epage opened this issue Jun 9, 2022 · 0 comments
Open

Deprecate ArgMatches::get_raw #3809

epage opened this issue Jun 9, 2022 · 0 comments
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-enhancement Category: Raise on the bar on expectations S-waiting-on-decision Status: Waiting on a go/no-go before implementing

Comments

@epage
Copy link
Member

epage commented Jun 9, 2022

Blocked on #3807 and #3808

With #3732, we added a typed API but provided get_raw as an escape hatch in case people need it. However, this means everyone pays the price for us tracking raw values.

With this, #3807, and #3808, we could stop tracking raw values and reduce some overhead
@epage epage added C-enhancement Category: Raise on the bar on expectations S-waiting-on-decision Status: Waiting on a go/no-go before implementing A-parsing Area: Parser's logic and needs it changed somehow. labels Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-enhancement Category: Raise on the bar on expectations S-waiting-on-decision Status: Waiting on a go/no-go before implementing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage