fix(builder): Fully recurse when building #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
force-pushed
the
panic
branch
2 times, most recently
from
c972e95
to
83b2188
Compare
Besides addressing the panic from assuming things were built when they weren't, this should fix some completion issues for some people. Fixes clap-rs#3669
pksunkara
reviewed
May 3, 2022
| self._build_self(); | ||
| for subcmd in self.get_subcommands_mut() { | ||
| subcmd._build_self(); | ||
| subcmd._build_recursive(); |
There was a problem hiding this comment.
AFAIK The reason for not building everything was performance concerns. We only built the subcommands people were using.
There was a problem hiding this comment.
There are two build paths. The incremental build path used by parsing and the "build all" build path used by completions, etc. They share _build_self but how they walk and how they generate bin names is separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides addressing the panic from assuming things were built when they
weren't, this should fix some completion issues for some people.
Fixes #3669