refactor(validator): Decouple parser #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had two different implementations of conflicts
- Validating conflicts
- Allowing conflicts to override `required`
- Missing members of a group conflicting with each other
- Missing symmetric conflicts (A conflicts with B so B conflicts with
A)
This consolidates their implementations which should fix overriding of
`required`.
Before, if two arguments were required *and* overrode each other, then `cmd --opt=1 --other=2` succeded but `cmd --other=2` failed despite ignoring `--opt=1`. Requiring `--opt=1` to be present but unavailable doesn't help anyone and makes the behavior less predictable. Now both commands will have the same behavior.
This isn't a parser policy but command-level policy.
epage
force-pushed
the
override_conflicts
branch
from
0257c97
to
9d52301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both makes intent clearer and will make it easier in the future to allow users to customize the parts
On the way to getting there, some of the refactors ended up fixing a couple of bugs