fix(derive): Couple derive version to clap #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `clap` depends on `clap_derive`, `clap_derive` inherently has a dependency on `clap` because it generates code assuming at least a specific clap version. If a new `clap_derive` is used with an old `clap`, it'll generate code that won't compile. We've kept things loose because of - Bad experiences with overly constrained version reqs - To not force new `clap` versions to release `clap_derive`. - People should have a lock file anyways The downsides: - `cargo install` does not use `Cargo.lock` by default, required `--locked` - If we want people to not skip non-patch releases when upgrading, we need it to not be a pain
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Jun 20, 2022
Summary: For: clap-rs/clap#3636 Reviewed By: IanChilds Differential Revision: D37273461 fbshipit-source-id: db58a28d70d6d2307ef58dc1f3f52e2e8e23b5e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
clapdepends onclap_derive,clap_deriveinherently has adependency on
clapbecause it generates code assuming at least aspecific clap version. If a new
clap_deriveis used with an oldclap, it'll generate code that won't compile.We've kept things loose because of
clapversions to releaseclap_derive.The downsides:
cargo installdoes not useCargo.lockby default, required--lockedneed it to not be a pain