Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgEnum non-unit variant #3591

Merged
merged 2 commits into from Mar 31, 2022
Merged

Fix ArgEnum non-unit variant #3591

merged 2 commits into from Mar 31, 2022

Conversation

Shir0kamii
Copy link
Contributor

Hi!

As promised, I tackled the issue #3543, which I reported.
Please tell me what you think, I will refactor it if needed.

@Shir0kamii Shir0kamii changed the title Fix arg enum non unit Fix ArgEnum non-unit variant Mar 30, 2022
@epage
Copy link
Member

epage commented Mar 31, 2022

Thanks!

@epage epage merged commit 71ef887 into clap-rs:master Mar 31, 2022
@epage
Copy link
Member

epage commented Mar 31, 2022

v3.1.7 is released with this

@Shir0kamii
Copy link
Contributor Author

Thanks for the reactivity and the insight of your comment!

@Shir0kamii Shir0kamii deleted the fix-ArgEnum-non-unit branch March 31, 2022 18:09
@Shir0kamii Shir0kamii mentioned this pull request Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shir0kamii @epage