fix: Change IntoApp::into_app to CommandFactory::command
#3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No good solution for transitioning the trate name, unfortnately, since we can't mark `use`s as deprecated (we can, it just does nothing). I got rid of the `into` prefix because that implies a `self` parameter that doesn't exist.
This is part of the `App` rename. Previously, I was concerned about not being able to deprecate For backwards compatibility, we still expose the `IntoApp` name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3472 and is part of resolving #3089.
With
Commandrenamed, we need to handle the renaming ofIntoApp::into_app.into_*functions are meant to takeselfas a parameter (see https://rust-lang.github.io/api-guidelines/naming.html#c-conv) which this does not. I think switching tocommandis sufficient for the function. That leaves naming the trait. Java has given a lot of us a negative feeling towards the nameFactorybut calling this aCommandFactoryis the best, descriptive name I've been able to come up with.For compatibility, we
pub use CommandFactory as IntoAppand havecommand()be an inherent function that calls the deprecatedinto_app. While in #3472, I shied away from usingusebecause it doesn't trigger the deprecation warning, this was the best option I had for a trait. This at least ensures all new users will use the new name and existing users are getting the opportunity to migrate, even if they won't get a notification.