Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(complete): Better organize the API #3236

Merged
merged 1 commit into from Dec 31, 2021
Merged

Conversation

epage
Copy link
Member

@epage epage commented Dec 31, 2021

No description provided.

@epage epage merged commit 0aa5fd2 into clap-rs:master Dec 31, 2021
@epage epage deleted the complete branch December 31, 2021 19:36
@pksunkara
Copy link
Member

I don't mind the rename, but I was stuck thinking that its weird that the generator is placed in clap_complete and the generator is more abstract than just completion. Maybe it's better if we place it in a separate package clap_generate and make clap_complete use it?

@epage
Copy link
Member Author

epage commented Dec 31, 2021

I don't mind the rename, but I was stuck thinking that its weird that the generator is placed in clap_complete and the generator is more abstract than just completion. Maybe it's better if we place it in a separate package clap_generate and make clap_complete use it?

We'll need to see how this evolves. Currently, the generator doesn't make sense for man pages. If it does make more sense, we can repurpose clap_generate (after a sufficient deprecation window) to instead be below clap_complete, like you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants