feat(derive): Don't require Display for default ArgEnum #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I'm unsure how much type specialization we should do, we intentionally have the `arg_enum` attribute for doing special behavior based on it, so let's take advantage of it. Fixes clap-rs#3185
2 tasks
|
that was quick |
|
v3.0.0-rc.6 is released with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm unsure how much type specialization we should do, we
intentionally have the
arg_enumattribute for doing special behaviorbased on it, so let's take advantage of it.
By loosening
PossibleValues lifetimes for this, we also avoid alazy_static!and string allocation.Fixes #3185