Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env feature gate #2694

Merged
merged 1 commit into from Aug 14, 2021
Merged

Add env feature gate #2694

merged 1 commit into from Aug 14, 2021

Conversation

pksunkara
Copy link
Member

Was looking at Kevin's recent changes in the modular branch and since we have DisableEnv setting, I felt like this is a better way to do it.

@pksunkara pksunkara requested a review from a team August 14, 2021 00:56
@pksunkara pksunkara added this to the 3.0 milestone Aug 14, 2021
Copy link
Member

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm making the assumption that we see no reason for someone to determine this at runtime.

I dislike the number of conditionals this requires though. I prefer to limit my conditionals to where I have a nice cut off point / can use a null module so knowledge of the feature doesn't leak everywhere. It complicates the code and makes it more likely that some untest combination of flags will fail..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants