Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 5 support #12

Closed
BoShurik opened this issue Nov 21, 2019 · 11 comments
Closed

Symfony 5 support #12

BoShurik opened this issue Nov 21, 2019 · 11 comments
Assignees

Comments

@BoShurik
Copy link
Contributor

Missed Symfony 5 support

@treeindark
Copy link

why kix:patch-1 not merged ?

@zaak
Copy link
Member

zaak commented Feb 24, 2020

Hi @treeindark. Thanks for the reminder, merged it.

@sasha172017
Copy link

how to install this bundle? composer shows error when install it on Symfony 5

@escees
Copy link

escees commented Mar 11, 2020

@zaak Monolog dependency needs to be fixed. SF5 comes with monolog 2.0.2 and this bundle is satisfied maximum by version 1.9.1. Are you able to update it or I need to create PR?

@IndyDevGuy
Copy link
Contributor

Left PR #16

@zaak
Copy link
Member

zaak commented Mar 28, 2020

@escees: Fixed by @IndyDevGuy in #16.

@IndyDevGuy
Copy link
Contributor

I had a typo in the composer.json. Take a look @ PR #17, should be good to go now.

@lightcoresystems
Copy link

lightcoresystems commented Mar 31, 2020

Hi there ! I got another problem with SF5. Commands now have to return a int value, but command "ckfinder:download" returns null..

Symfony change: symfony/symfony#33747

EDIT: I have created PR #18 repairing this issue

@treeindark
Copy link

  • integration in Symfony 5 returns error “no container set”
    add in services.yaml :

CKSource\Bundle\CKFinderBundle\Controller\CKFinderController: calls: - [setContainer, ['@service_container']]

Ok but now :
`

Argument 1 passed to CKSource\CKFinder\ExceptionHandler::onCKFinderError() must be an instance of Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent, instance of Symfony\Component\HttpKernel\Event\ExceptionEvent given, called in D:\Web\Foody_dck\vendor\symfony\event-dispatcher\EventDispatcher.php on line 230

`
migration sf5 ???

@zaak zaak self-assigned this Apr 22, 2020
@zaak
Copy link
Member

zaak commented Apr 22, 2020

We have started work on Symfony 5 support. The new version of the bundle should be released within 2 weeks.

@zaak
Copy link
Member

zaak commented May 5, 2020

Symfony 5 support has been added in v3.5.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants