Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise support #2962

Closed
jacekbogdanski opened this issue Mar 18, 2019 · 0 comments · Fixed by #2988
Closed

Promise support #2962

jacekbogdanski opened this issue Mar 18, 2019 · 0 comments · Fixed by #2988
Assignees
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Mar 18, 2019

Type of report

Feature request

Provide description of the new feature

It seems to be a good time to provide Promise support for CKEditor4. It's already required and somehow implemented in our testing environment (see #2752) although it would be nice to have dedicated CKEDITOR.tools.promise as a wrapper around native Promise object which will also handle polyfilling for IE. We should discuss polyfill library options - it doesn't make sense to spend time reinventing the wheel again.

Some requirements / things to discuss :

  1. Use native Promise everytime when it's possible.
  2. Load polyfill library asynchronously only for the browsers with no Promise support when needed.
  3. Choose polyfill library with the same API as Promise.
  4. Hide Promise under CKEDITOR.tools.promise namespace so we won't overwrite native objects.
@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Mar 18, 2019
@jacekbogdanski jacekbogdanski self-assigned this Mar 26, 2019
@jacekbogdanski jacekbogdanski mentioned this issue Mar 27, 2019
2 tasks
@f1ames f1ames added this to the 4.12.0 milestone May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants