Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CKEDITOR.tools.array.find method #2700

Closed
engineering-this opened this issue Dec 21, 2018 · 0 comments
Closed

Add CKEDITOR.tools.array.find method #2700

engineering-this opened this issue Dec 21, 2018 · 0 comments
Assignees
@engineering-this
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.12.0

Comments

@engineering-this
Copy link
Contributor

Type of report

Feature request

Provide description of the new feature

This method could simplify some of our code, it could be used by #2698

CKEDITOR.tools.array.find( array, fn, [ thisArg ] )

Specs: https://www.ecma-international.org/ecma-262/6.0/#sec-array.prototype.find
@engineering-this engineering-this added type:feature A feature request. status:confirmed An issue confirmed by the development team. labels Dec 21, 2018
@engineering-this engineering-this self-assigned this Dec 21, 2018
@engineering-this engineering-this mentioned this issue Dec 28, 2018
Merged
2 tasks
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. changelog:api A changelog entry should be put in the API section of the changelog. target:major Any docs related issue that should be merged into a major branch. labels Jan 2, 2019
@mlewand mlewand added this to the 4.12.0 milestone Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.12.0
Development

No branches or pull requests
2 participants
@mlewand @engineering-this