Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Toolbar context should expose a way to reposition the context #1496

Closed
mlewand opened this issue Jan 24, 2018 · 0 comments
Closed

Balloon Toolbar context should expose a way to reposition the context #1496

mlewand opened this issue Jan 24, 2018 · 0 comments
Assignees
@engineering-this
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Milestone
4.12.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Jan 24, 2018

Are you reporting a feature request or a bug?

Feature request

Provide detailed reproduction steps (if any)

While working on Easy Image plugin we had a requirement to reposition the balloon under in a certain scenario.

Here the case was that the image was loaded asynchronously, and the default balloon toolbar matching happened too early (when the image size was not yet known) thus the balloon was mispositioned.

In turn we used Balloon Toolbar internal methods to do that, however there should be a nice method to force refresh of a toolbar.
@mlewand mlewand added type:feature A feature request. status:confirmed An issue confirmed by the development team. plugin:balloontoolbar The plugin which probably causes the issue. labels Jan 24, 2018
@mlewand mlewand added this to the Backlog milestone Jan 24, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:major Any docs related issue that should be merged into a major branch. changelog:api A changelog entry should be put in the API section of the changelog. labels Jan 24, 2018
@mlewand mlewand mentioned this issue Jan 24, 2018
Merged
2 tasks
@mlewand mlewand modified the milestones: Backlog, 4.12.0 Dec 10, 2018
@engineering-this engineering-this self-assigned this Dec 10, 2018
@engineering-this engineering-this mentioned this issue Dec 11, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:feature A feature request.
Projects
None yet
Milestone
4.12.0
Development

No branches or pull requests
2 participants
@mlewand @engineering-this