Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookiecutter Tests and pre-commit workflows should use separate caches #648

Closed
cjolowicz opened this issue Nov 3, 2020 · 1 comment
Closed
Labels
bug Something isn't working cookiecutter Changes outside of the template directory
Milestone

Comments

@cjolowicz
Copy link
Owner

pre-commit environments are cached in the Tests and pre-commit workflows of the Cookiecutter. Caches are scoped to the key and branch, and both workflows use the same cache key format. These environments are quite different, however; the one in the Tests workflow is for generated projects and only has Prettier, while the one in the pre-commit workflow is for the Cookiecutter and has both Prettier and pre-commit-hooks. We should either differentiate the cache keys, or drop caching (see #640).

@cjolowicz cjolowicz added the bug Something isn't working label Nov 3, 2020
@cjolowicz cjolowicz added this to the 2020.11.15 milestone Nov 3, 2020
@cjolowicz cjolowicz added the cookiecutter Changes outside of the template directory label Nov 3, 2020
@cjolowicz
Copy link
Owner Author

They would only use the same cache if the .pre-commit-config.yaml were identical (in which case it would be fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cookiecutter Changes outside of the template directory
Projects
None yet
Development

No branches or pull requests

1 participant