Bridgetown fails to build against view_component 3.9 #3145
Comments
|
@davidrapson I've had a look at that last Friday but reached a bit of a deadend. What I found so far was that it happens because of the "Ensure HTML output safety" feature which was added to in view_component 3.9: https://github.com/ViewComponent/view_component/pull/1950/files#diff-b69c75ffd85596e0b5fca1327059ecf3b2930f3f77004c78a268fa85e8ec8d9eR310. I think the problem is that in Bridgetown |
|
Yeah that looks like it! I think the "two years ago" on bridgetown-view-component is misleading, the last release was Jan 2023. Going to pin the version for now but if you are up for it I reckon it's worth seeing if we can pull together a reduced test case bridgetown project with just enough set up to reproduce the issue. If it does end up being something that needs fixing upstream having a good minimal example of the issue will help us fix it. |
|
Sounds like a good plan, thanks! Not sure when I'll have the chance to look further into it though - meaning that it's open to anyone who's interested in the meanwhile. |
ViewComponent 3.9+ introduced a change which depends on there being an active Rails request or controller in order to conditionally escape HTML. This causes an issue when run in bridgetown as there's no request and we're always rendering static html. Monkey patch the relevant method to remove the request format check. Fixes #3145
ViewComponent 3.9+ introduced a change which depends on there being an active Rails request or controller in order to conditionally escape HTML. This causes an issue when run in bridgetown as there's no request and we're always rendering static html. Monkey patch the relevant method to remove the request format check. Fixes #3145
ViewComponent 3.9+ introduced a change which depends on there being an active Rails request or controller in order to conditionally escape HTML. This causes an issue when run in bridgetown as there's no request and we're always rendering static html. Monkey patch the relevant method to remove the request format check. Fixes #3145
ViewComponent 3.9+ introduced a change which depends on there being an active Rails request or controller in order to conditionally escape HTML. This causes an issue when run in bridgetown as there's no request and we're always rendering static html. Monkey patch the relevant method to remove the request format check. Fixes #3145
The bridgetown project fails to build when updated to view_component 3.9. We should investigate the cause and potentially create a reduced test case to confirm if the issue can be replicated using a fresh bridgetown install.
Related issue: bridgetownrb/bridgetown-view-component#8
The text was updated successfully, but these errors were encountered: