Add missing foundation colours and deprecate duplicate colour variable #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing status colours to the foundations documentation Fixes #3031
The `$cads-language__warning-colour` variable is a duplicate of `$cads-language__error-colour` and is used interchangeably. Remove internal references to the duplicate variable and document it as deprecated.
davidrapson
force-pushed
the
add-missing-foundation-colours
branch
from
08e0e0b
to
6b5c3d6
Compare
|
I've also noticed the callout backgrounds are not specified. It looks like they are a 10% mix with white, but seeing this note on Tailwind, it might be better to specify them explicitly. |
|
Also the success background is implemented differently and is a 10% opacity of the foreground rather than a 10% mix of white? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3031
Adds missing status colours to the foundations documentation. In the process realised that
$cads-language__warning-colouris a duplicate of$cads-language__error-colour. I've removed internal references to the duplicate variable and document it as deprecated.We could simply remove the variable and require applications to replace the reference or leave it for a little while and replace it more gradually. There's no way to add a deprecation warning to a plain variable.