Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick a single build tool for javascript modules #1399

Open
davidsauntson opened this issue Aug 5, 2021 · 2 comments
Open

Pick a single build tool for javascript modules #1399

davidsauntson opened this issue Aug 5, 2021 · 2 comments
Labels
tech debt Technical tasks that would usually form a contribution
Projects
💫 Bugs & Tech debt

Comments

@davidsauntson
Copy link
Contributor

We only have three javascript modules in the design system yet two separate build systems. We should pick one.

  • JavaScript vs TypeScript for everything
  • Single build tool (rollup is pretty common for library code)
@davidsauntson davidsauntson added the tech debt Technical tasks that would usually form a contribution label Aug 5, 2021
@davidsauntson davidsauntson added this to Needs triage in 💫 Bugs & Tech debt via automation Aug 5, 2021
@davidsauntson davidsauntson moved this from Needs assessment to In progress in 💫 Bugs & Tech debt Oct 25, 2021
@davidsauntson
Copy link
Contributor Author

Picking this up with the following overall plan:

  • fix greedy nav build so that it only outputs the current module in use and simplify ts configs
  • refactor header.js into ts
  • refactor targeted-content.js into ts
  • use tsc to build all the ts. Looking at the docs it seems like the recommended approach as we want multiple outputs available for individual inclusion in consuming products

@davidrapson whaddya reckon?

@davidsauntson davidsauntson mentioned this issue Oct 25, 2021
Merged
@davidrapson
Copy link
Contributor

👍 This all makes sense to me!

@davidsauntson davidsauntson mentioned this issue Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Technical tasks that would usually form a contribution
Projects
💫 Bugs & Tech debt
In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidrapson @davidsauntson