From 2bb3af75414e626da6e2061c5e6de05b09452f59 Mon Sep 17 00:00:00 2001 From: Simon Gill Date: Mon, 14 Sep 2020 17:56:45 +0100 Subject: [PATCH 1/4] Update citizens-advice-style.gemspec --- citizens-advice-style.gemspec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/citizens-advice-style.gemspec b/citizens-advice-style.gemspec index 9b69b6f..3dc49ad 100644 --- a/citizens-advice-style.gemspec +++ b/citizens-advice-style.gemspec @@ -40,4 +40,8 @@ Gem::Specification.new do |spec| # cop names. Allowing just patch updates should prevent this happening. # When rubocop is upgraded here, this gem should get a minor version update as well. spec.add_dependency "rubocop", "~> 0.85.1" + + # In earlier versions, rubocop could find the DidYouMean module through ruby's default gems. + # This seems to have changed so that it must now be added to the Gemfile. + spec.add_dependency "did_you_mean", "~> 1.4.0" end From 66f99413165daee24d8e87a13f7abd96f655bf94 Mon Sep 17 00:00:00 2001 From: Simon Gill Date: Mon, 14 Sep 2020 17:57:58 +0100 Subject: [PATCH 2/4] Update version.rb --- lib/citizens-advice/style/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/citizens-advice/style/version.rb b/lib/citizens-advice/style/version.rb index a622d58..40efca4 100644 --- a/lib/citizens-advice/style/version.rb +++ b/lib/citizens-advice/style/version.rb @@ -2,6 +2,6 @@ module CitizensAdvice module Style - VERSION = "0.3.0" + VERSION = "0.3.1" end end From fd2c2304ba55fb903ef1f73ad60b46cc110583d3 Mon Sep 17 00:00:00 2001 From: Simon Gill Date: Thu, 17 Sep 2020 11:41:59 +0100 Subject: [PATCH 3/4] Update citizens-advice-style.gemspec Fix that would avoid needing to load did_you_mean is apparently in 0.87 so trying that. --- citizens-advice-style.gemspec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/citizens-advice-style.gemspec b/citizens-advice-style.gemspec index 3dc49ad..84eed7b 100644 --- a/citizens-advice-style.gemspec +++ b/citizens-advice-style.gemspec @@ -39,9 +39,9 @@ Gem::Specification.new do |spec| # A working configuration can suddenly become a problem if rubocop deprecates or changes # cop names. Allowing just patch updates should prevent this happening. # When rubocop is upgraded here, this gem should get a minor version update as well. - spec.add_dependency "rubocop", "~> 0.85.1" + spec.add_dependency "rubocop", "~> 0.87.0" # In earlier versions, rubocop could find the DidYouMean module through ruby's default gems. # This seems to have changed so that it must now be added to the Gemfile. - spec.add_dependency "did_you_mean", "~> 1.4.0" + # spec.add_dependency "did_you_mean", "~> 1.4.0" end From 03abc477cdfc5de603dcd97753a7931595ac6e39 Mon Sep 17 00:00:00 2001 From: Simon Gill Date: Thu, 17 Sep 2020 11:45:54 +0100 Subject: [PATCH 4/4] Update citizens-advice-style.gemspec Tested this within devops-tools, going to 0.87 does indeed fix the error reporting issue. --- citizens-advice-style.gemspec | 4 ---- 1 file changed, 4 deletions(-) diff --git a/citizens-advice-style.gemspec b/citizens-advice-style.gemspec index 84eed7b..0bb7bb6 100644 --- a/citizens-advice-style.gemspec +++ b/citizens-advice-style.gemspec @@ -40,8 +40,4 @@ Gem::Specification.new do |spec| # cop names. Allowing just patch updates should prevent this happening. # When rubocop is upgraded here, this gem should get a minor version update as well. spec.add_dependency "rubocop", "~> 0.87.0" - - # In earlier versions, rubocop could find the DidYouMean module through ruby's default gems. - # This seems to have changed so that it must now be added to the Gemfile. - # spec.add_dependency "did_you_mean", "~> 1.4.0" end