Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product names list not check for unique #171

Closed
crutchfield opened this issue Mar 1, 2023 · 7 comments 路 Fixed by #782
Closed

Product names list not check for unique #171

crutchfield opened this issue Mar 1, 2023 · 7 comments 路 Fixed by #782
Assignees
@twneale
Labels
bug This issue or pull request addresses broken functionality good first issue This issue or pull request is well-defined and good for newcomers
Milestone
Halibut

Comments

@crutchfield
Copy link
Contributor

馃悰 Summary

The orchestrator assumes the provided product names are unique. We do not check to verify.

To reproduce

Steps to reproduce the behavior:

  1. Invoke-Scuba -ProductNames aad, aad

Expected behavior

We should either reject Product names parameter as invalid or Get-Uniqu when we sort the product names in the rchestrator.

What did you expect to happen that didn't?

Log into service once as needed.
@crutchfield crutchfield added the bug This issue or pull request addresses broken functionality label Mar 1, 2023
@crutchfield crutchfield added this to the Backlog milestone Mar 1, 2023
@Sloane4 Sloane4 self-assigned this Jun 23, 2023
@tkol2022
Copy link
Collaborator

Reviewed 12/14

@crutchfield Please review to ensure this is still valid and not OBE. If it has been taken care of, please close the issue.

@crutchfield
Copy link
Contributor Author

Reviewed 12/14

@crutchfield Please review to ensure this is still valid and not OBE. If it has been taken care of, please close the issue.

Issue is still valid. Set size to tiny.

@schrolla
Copy link
Collaborator

Convert list to set to make sure it only runs once for each product and silently continue.

@schrolla schrolla added the good first issue This issue or pull request is well-defined and good for newcomers label Dec 15, 2023
@twneale twneale self-assigned this Jan 4, 2024
@twneale twneale mentioned this issue Jan 4, 2024
Closed
12 tasks
@twneale
Copy link
Collaborator

twneale commented Jan 4, 2024

I'll try to fumble my way through a well-formed PR with this one.

@schrolla
Copy link
Collaborator

schrolla commented Jan 4, 2024 •
edited

One other thought, ProductNames can also be created and specified via config file. So you probably want to make sure the same uniqueness is applied when product names are taken from a config file as well.

@Sloane4
Copy link
Collaborator

Sloane4 commented Jan 5, 2024

Should monitor issue #190 as it can affect this issue

@twneale
Copy link
Collaborator

twneale commented Jan 8, 2024

Updated the PR with two more changes, one to address product names coming form the config file, and another where ProductNames is used in Invoke-RunCached.

@twneale twneale mentioned this issue Jan 9, 2024
Merged
12 tasks
@schrolla schrolla modified the milestones: Backlog, Glacier Feb 26, 2024
@schrolla schrolla modified the milestones: Glacier, Halibut Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twneale twneale

Labels
bug This issue or pull request addresses broken functionality good first issue This issue or pull request is well-defined and good for newcomers
Projects
None yet
Milestone
Halibut
5 participants
@twneale @crutchfield @Sloane4 @tkol2022 @schrolla