Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Expand ~ into $HOME in the cache's folder field #47

Open
edigaryev opened this issue Sep 29, 2020 · 0 comments
Open

Expand ~ into $HOME in the cache's folder field #47

edigaryev opened this issue Sep 29, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@edigaryev
Copy link
Contributor

Currently this expansion is done in the cloud, and since we're currently in the process of migrating from RPC parser to in-house parser, this is a good time to do this closer to the actual Unix shell.

@fkorotkov says that it should probably be done here:

cirrus-ci-agent/internal/executor/cache.go

Line 58 in ec41fbb

folderToCache := ExpandText(instruction.Folder, custom_env)

@fkorotkov fkorotkov added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edigaryev @fkorotkov