Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic rebase on pushes to base branch #1

Open
fkorotkov opened this issue Jan 22, 2019 · 8 comments
Open

Automatic rebase on pushes to base branch #1

fkorotkov opened this issue Jan 22, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@fkorotkov
Copy link
Member

It will be nice to have an option to trigger the action on push events to a branch to rebase all PRs that want to merge into this branch.

@ljharb
Copy link

ljharb commented Jan 22, 2019

All pushes would be nice, but I’d personally want to restrict it to the “update branch” button, both so it doesn’t autorebase every time i push on the cli (even if it’s already rebased), and so it’s an explicit action separate from pushes.

@fkorotkov fkorotkov added the enhancement New feature or request label Jan 22, 2019
@piranna
Copy link

piranna commented Feb 15, 2019

Maybe can be configurable to what branches should do the rebase? Or instead rebase, maybe merge from master...

@ljharb
Copy link

ljharb commented Feb 15, 2019

Certainly I'd expect any and every github action to be configurable just like branch protections - to target all branches, specific branches, or just branches matching a pattern.

@piranna
Copy link

piranna commented Feb 15, 2019

Certainly I'd expect any and every github action to be configurable just like branch protections - to target all branches, specific branches, or just branches matching a pattern.

maybe https://github.com/actions/bin/tree/master/filter would do the trick

@mrpandat
Copy link

Hey, any update on this issue ?

Would love to contribute if someone can give me some help to do this. 👍

@fkorotkov
Copy link
Member Author

@mrpandat no progress on this issue so far.

I've only though about a possible solution. IMO such feature is not that generic because for repositories with high amount of commits it can overwhelm CI. And as @ljharb most likely you want to explicitly trigger such batch rebase only for PRs that do some breaking changes to APIs or just massive refactorings.

I think the easiest solution will be to create a separate action (or separate script within this action) that upon a comment like /rebase-open-prs to an already merged PR will comment with /rebase because of #<PR NUMBER> in all PRs targeting the same branch.

@cirrus-actions cirrus-actions deleted a comment Jan 1, 2020
@cirrus-actions cirrus-actions deleted a comment Feb 27, 2020
@omar1326
Copy link

entrypoint.sh

@gsuess
Copy link

gsuess commented Oct 5, 2020

The danger of an autonomous rebase is that the rebase involves a force-push. So unless great care if taking there is a potentially that some commits by PR author will be overridden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants