Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined version update for JS and JVM #2267

Open
lpawlak1 opened this issue May 13, 2024 · 4 comments
Open

Refined version update for JS and JVM #2267

lpawlak1 opened this issue May 13, 2024 · 4 comments

Comments

@lpawlak1
Copy link

Hi team,

Based on links below I can see that refinedVersion has not been bumped due to bin compat concerns, are there any plans to bump it in near future?

This would allow to move to Scala 3 in some projects as shapeless in 2.13 scala version is used in refined version 0.9.29 and they removed this dependency in 0.11.1

Thanks, Łukasz

#2047
#2231

@hamnis
Copy link
Collaborator

hamnis commented May 13, 2024

#2231 has already been merged.

@lpawlak1
Copy link
Author

Hey,

based on this snippet from build.sbt

lazy val refined = circeCrossModule("refined")
  .settings(
    tlVersionIntroduced += "3" -> "0.14.3",
    libraryDependencies ++= {
      val refinedV =
        if (crossProjectPlatform.value == NativePlatform) refinedNativeVersion
        else refinedVersion
      Seq(
        "eu.timepit" %%% "refined" % refinedV,
        "eu.timepit" %%% "refined-scalacheck" % refinedV % Test
      )
    },
...
val refinedVersion = "0.9.29"
val refinedNativeVersion = "0.11.1"

Refined was actually bumped only for NativePlatform, but not for JVMPlatform :/

Is this possible to add version bump also for JVMPlatform? 😃

@lpawlak1 lpawlak1 changed the title Refined version update Refined version update for JS and JVM May 13, 2024
@hamnis
Copy link
Collaborator

hamnis commented May 13, 2024

oh, i didnt realize. Will have a look.

@hamnis
Copy link
Collaborator

hamnis commented Jun 1, 2024

will be done as part of #2276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants