Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from brb/ebpf (fork) to cilium/ebpf #8

Closed
brb opened this issue Oct 15, 2021 · 3 comments · Fixed by #61
Closed

Switch from brb/ebpf (fork) to cilium/ebpf #8

brb opened this issue Oct 15, 2021 · 3 comments · Fixed by #61
Assignees
@brb
Labels
cleanup help wanted Extra attention is needed

Comments

@brb
Copy link
Member

brb commented Oct 15, 2021

This requires the following in cilium/ebpf:

  • Exposing internal/btf package.
  • Implementing iterator.

See https://github.com/brb/ebpf/tree/pwru for the diff.
@brb brb added this to the v0.0.2 milestone Oct 15, 2021
@brb brb added the cleanup label Oct 21, 2021
@alban alban mentioned this issue Oct 23, 2021
Closed
3 tasks
@brb brb unassigned ti-mo Jan 24, 2022
@brb brb removed this from the v0.0.2 milestone Jan 24, 2022
@brb brb added the help wanted Extra attention is needed label Jan 24, 2022
@tklauser
Copy link
Member

This requires the following in cilium/ebpf:

  • Exposing internal/btf package.

It seems the btf package was recently exported: cilium/ebpf#665

  • Implementing iterator.

So I think the missing Iterate method (or whatever the cilium/ebpf maintainers deem appropriate) is all that's missing to switch to cilium/ebpf.

@brb
Copy link
Member Author

brb commented May 16, 2022

Aye, I am planning to add a getter for namedTypes instead of adding the Iterate method.

@brb brb self-assigned this May 17, 2022
tklauser added a commit that referenced this issue May 23, 2022
@tklauser
.github: add dependabot configuration
620e603 
Let dependabot update Go modules and GH actions. Don't update
cilium/ebpf for now until #8 is resolved and the brb/ebpf fork can be
dropped.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@brb
Copy link
Member Author

brb commented May 23, 2022

The PR for the iterator is out - cilium/ebpf#678.

brb pushed a commit that referenced this issue May 23, 2022
@tklauser @brb
.github: add dependabot configuration
077fd49 
Let dependabot update Go modules and GH actions. Don't update
cilium/ebpf for now until #8 is resolved and the brb/ebpf fork can be
dropped.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@brb brb mentioned this issue May 23, 2022
Merged
@brb brb closed this as completed in #61 May 23, 2022
tklauser added a commit that referenced this issue May 24, 2022
@tklauser
.github: un-ignore cilium/ebpf in dependabot config
ca0b528 
Now that #8 is resolved and pwru uses upstream cilium/ebpf, let
dependabot update it automatically to new releaes.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
brb pushed a commit that referenced this issue May 24, 2022
@tklauser @brb
.github: un-ignore cilium/ebpf in dependabot config
91a539a 
Now that #8 is resolved and pwru uses upstream cilium/ebpf, let
dependabot update it automatically to new releaes.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brb brb

Labels
cleanup help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to gh/cilium/ebpf cilium/pwru
3 participants
@brb @tklauser @ti-mo