Fix tests by only flushing gzip writer once #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing the gzip writer causes a flush, and doesn't actually close the underlying file, so we can switch to closing the gzip writer before closing the underlying file, instead of using Flush(). The previous approach of Flushing and then Closing caused us to flush twice, which had the side-effect of causing the underlying file to have an additional 5 bytes of data that was not expected in our tests. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
michi-covalent
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing the gzip writer causes a flush, and doesn't actually close the underlying file, so we can switch to closing the gzip writer before closing the underlying file, instead of using Flush(). The previous approach of Flushing and then Closing caused us to flush twice, which had the side-effect of causing the underlying file to have an additional 5 bytes of data that was not expected in our tests.