permissions: allow to set custom permission bits on log files #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test by appending tmpSuffix as the hooked chown inside compressLogFile() is called on a tmp file, that is to be saved in the fakefs map. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
This adds the FileMode field to allow setting custom permission bits on log files. We have use cases where the logs should be viewed only by privileged. This custom FileMode is used only if set by callers. It does not perform validation on the passed permissions and code is kept minimal. Callers should know what to pass. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
Adds: - Mutliple tests to check if testMaintainMode() maintains the mode and that rotated logs do also have the right permissions. - TestFileModeIsSet() to assert fileModeIsSet() Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
This tests testCompressMaintainMode() with multiple custom valid permissions, and non valid or non set ones, to ensure that we fallback to default mode. Signed-off-by: Djalal Harouni <tixxdz@gmail.com>
chancez
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the FileMode field to allow setting custom permission bits
on log files. We have use cases where the logs should be viewed only
by privileged.
This custom FileMode is used only if set by callers. It does not
perform validation on the passed permissions and code is kept minimal.
Callers should know what to pass.
Signed-off-by: Djalal Harouni tixxdz@gmail.com