New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf2go: use [16]byte instead of uint128 #799

Merged

lmb merged 1 commit into cilium:master from Benjamin-Yim:reopen_fix_uint128

Sep 23, 2022

Contributor

Benjamin-Yim commented Sep 21, 2022

The latest code seems to have changed quite a bit so it was changed to:

...
	case Unsigned, Signed:
		stem := "uint"
		if i.Encoding == Signed {
			stem = "int"
		}
		if i.Size > 8 {
			fmt.Fprintf(&gf.w, "[%d]byte /* %s%d */", i.Size, stem, i.Size*8)
		} else {
			fmt.Fprintf(&gf.w, "%s%d", stem, bits)
		}


          fix uint128

cad8544

Benjamin-Yim mentioned this pull request

may uint128 to [16]byte #785

Closed

lmb merged commit bb83b7f into cilium:master

Collaborator

lmb commented Sep 23, 2022

@Benjamin-Yim thank you for your contribution, sorry it took so long to merge.

lmb changed the title ~~reopen may uint128 to [16]byte~~ bpf2go: use [16]byte instead of uint128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment