link: (u|k)probe: don't treat EINVAL as os.ErrNotExist #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
am I wrong or we are not catching EINVAL at all? |
|
This may be the sleep deprivation talking, but EINVAL would be handled by the |
🙈 true, didn't notice it, LGTM! looks like a 4.14 test needs to be adjusted |
mmat11
approved these changes
Jul 28, 2022
|
Thanks Timo! |
lmb
approved these changes
Jul 28, 2022
Running TestUprobeExtWithOpts on arm64 currently gives a weird error:
uprobe_test.go:101: creating perf_uprobe PMU: symbol 'open+0x1' not found: file does not exist
Investigating via strace shows that perf_event_open returns EINVAL:
perf_event_open({type=0x7 /* PERF_TYPE_??? */, size=PERF_ATTR_SIZE_VER1, ...}, -1, 0, -1, PERF_FLAG_FD_CLOEXEC) = -1 EINVAL (Invalid argument)
We map this to ENOENT since older kernels don't return a useful error
when the target function doesn't exist. The example above shows that this is
too broad.
Stop mapping EINVAL to ENOENT.
Co-authored-by: Timo Beckers <timo@isovalent.com>
The tracefs probes have used a 'token' to represent their ksym:offset tuples for some time, but PMUs take those values as separate fields in the syscall. This commit harmonizes the two, making errors more consistent across both APIs. Also makes sure the token is included in all errors, regardless of the type. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/perf-event-einval
branch
from
a067f5a
to
375841a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #745.
No longer treat EINVAL from creating u/k(ret)probes as
os.ErrNotExist, since EINVAL has many potential causes. This is a potentially breaking change, since callers scanning valid instruction offsets in symbols must now expect bothos.ErrNotExistas well asos.EINVAL, depending on the kernel version and architecture.Make errors shorter and more specific, e.g. 'bad insn boundary' no longer includes a 'not found' string. Token is now included in all errors, even unrecognized ones.