Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection: Rename CollectionSpec.BTF to .Types, copy in Copy() #581

Merged
merged 2 commits into from Feb 23, 2022

Conversation

ti-mo
Copy link
Collaborator

@ti-mo ti-mo commented Feb 22, 2022

In preparation of renaming the btf.Spec type itself down the line, once .BTF.ext data has been lifted into per-insn metadata, cement the interface that will be used to query the CollectionSpec for its type information.

A CollectionSpec now provides Maps, Programs and Types.


Also fix CollectionSpec.Copy() not copying Types.

@ti-mo ti-mo requested a review from lmb February 22, 2022 14:44
Without this, loading a copied CollectionSpec fails with:

loading collection: map test: BTF doesn't match collection

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo changed the title Copy CollectionSpec.BTF, unexport it collection: Rename CollectionSpec.BTF to .Types, copy in Copy() Feb 22, 2022
In preparation of renaming the btf.Spec type itself down the line, once
.BTF.ext data has been lifted into per-insn metadata, cement the interface
that will be used to query the CollectionSpec for its type information.

A CollectionSpec now provides Maps, Programs and Types.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo merged commit 4785297 into cilium:master Feb 23, 2022
@ti-mo ti-mo deleted the tb/collspec-copy-btf branch February 23, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant