bpf2go: generate Go types from BTF #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
bpf2go-gen-types
branch
3 times, most recently
from
c1d1fc8
to
97f9460
Compare
|
FWIW, I think it'd be really useful to also generate BTF_KIND_DATASEC types as well. Maybe not in this PR since this library doesn't support reading globals from collections yet. I added similar stuff in libbpf-rs and it was quite useful there. I miss it a lot in go land :) |
|
Yes, definitely. The code can already emit Datasec, but I don't yet know how to expose a sensible API for that. |
|
Neat! Looks like you found a use for |
ti-mo
approved these changes
Feb 2, 2022
Add a function which allows finding a type by name alone. This is useful for code that doesn't care about the concrete type returned.
Export an infallible version of skipQualifiersAndTypedef. Circular types / very long chains of qualifiers or typedefs are a corner case that shouldn't really happen, so let's not burden the callers with this detail.
Use GoFormatter to generate type definitions for types used as map keys and values. Allow users to emit additional types via a command line flag.
lmb
force-pushed
the
bpf2go-gen-types
branch
from
97f9460
to
b07a66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been sitting in my repo for too long. The basic idea is to use BTF to generate Go type equivalents of C types. By default we will do this for all types referenced as
keyorvaluefrom BTF map definitions.Adapting examples would look like this: lmb@1ce17d8
cmd/bpf2go: generate types from BTF
collection: expose BTF spec
btf: export UnderlyingType
btf: allow finding type by name alone