Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map: use batch lookups in Map.Iterate() #1079

Open
ti-mo opened this issue Jun 27, 2023 · 1 comment
Open

map: use batch lookups in Map.Iterate() #1079

ti-mo opened this issue Jun 27, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ti-mo
Copy link
Collaborator

ti-mo commented Jun 27, 2023

I would like to discuss the future of the Map Iterator API. Currently, it doesn't transparently use batch lookups under the hood
However, the current batch API, as it is in the library, is relatively barebones, and it hasn't been iterated on since its inception or integrated with other parts of the Map API.

Maybe it could be an option to either break the API of the current Map.Iterate() (and make it take a config struct),
or introduce a new Map.Range() or Map.For() method that takes a configuration struct. Or maybe simply Map.IterateBatch(), but that sounds rather unimaginative.

Ideally, we'd have a unified API where the caller can disable batch lookups if needed for certain use cases. Thinking
of hash map clearing where each call to .Next() is expected to point at the first element, which gets subsequently deleted.

Wondering if anyone's thought about this before, or if there's any opinions around this. Thanks!

@ti-mo ti-mo added enhancement New feature or request question labels Jun 27, 2023
@lmb lmb changed the title Integrating batch lookups into Map.Iterate() map: use batch lookups in Map.Iterate() Nov 1, 2023
@lmb
Copy link
Collaborator

lmb commented Nov 1, 2023

I would love it if Map.Iterate transparently used batch lookups if possible. (Less of a fan of a new API, we might have to break compat when / if Go gets iterators.) The devil is in the details though:

  • How many keys and values do we fetch in one go? There is not really a number that is correct for all cases. I'd probably start with a heuristic of using a page of memory for keys and values each, something like os.Getpagesize() / Sizeof(T). Allow the user to override that somehow. MapIterator.Items or something like that?
  • How do we deal with differences in semantics? For example, right now concurrent iteration and delete is undefined behaviour. I don't expect that to change with batch lookup (can't get more undefined) but is there a difference in practice to the reset behaviour we get for single key lookups?

@lmb lmb added help wanted Extra attention is needed and removed question labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants