From c80c08d1b73e35d6475018904f7385a7c4af307f Mon Sep 17 00:00:00 2001 From: Lorenz Bauer Date: Fri, 6 May 2022 15:32:44 +0000 Subject: [PATCH] ringbuf: fix BenchmarkReader Move calls to ResetTimer and ReportAllocs and avoid allocating a temporary buffer. --- ringbuf/reader_test.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ringbuf/reader_test.go b/ringbuf/reader_test.go index 71278fbb6..34ef6ec8f 100644 --- a/ringbuf/reader_test.go +++ b/ringbuf/reader_test.go @@ -224,9 +224,6 @@ func BenchmarkReader(b *testing.B) { }, } - b.ResetTimer() - b.ReportAllocs() - for _, bm := range readerBenchmarks { b.Run(bm.name, func(b *testing.B) { prog, events := mustOutputSamplesProg(b, bm.flags, 80) @@ -237,8 +234,13 @@ func BenchmarkReader(b *testing.B) { } defer rd.Close() + buf := make([]byte, 14) + + b.ResetTimer() + b.ReportAllocs() + for i := 0; i < b.N; i++ { - ret, _, err := prog.Benchmark(make([]byte, 14), 1, nil) + ret, _, err := prog.Test(buf) if err != nil { b.Fatal(err) } else if errno := syscall.Errno(-int32(ret)); errno != 0 {