Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: xdp: replace inline assembly in csum helpers #29487

Open
julianwiedmann opened this issue Nov 29, 2023 · 1 comment · May be fixed by #32543
Open

bpf: xdp: replace inline assembly in csum helpers #29487

julianwiedmann opened this issue Nov 29, 2023 · 1 comment · May be fixed by #32543
Assignees
@Jack-R-lantern
Labels
kind/enhancement This would improve or streamline existing functionality. pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.

Comments

@julianwiedmann
Copy link
Member

Now that we have native support for bpf_xdp_load_bytes(), wouldn't it be nice if we also replaced the inline assembly in

cilium/bpf/include/bpf/ctx/xdp.h

Line 167 in 82dbff8

asm volatile("r1 = *(u32 *)(%[ctx] +0)\n\t"
and

cilium/bpf/include/bpf/ctx/xdp.h

Line 204 in 82dbff8

asm volatile("r1 = *(u32 *)(%[ctx] +0)\n\t"
.
@julianwiedmann julianwiedmann added kind/enhancement This would improve or streamline existing functionality. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. pinned These issues are not marked stale by our issue bot. labels Nov 29, 2023
@Jack-R-lantern Jack-R-lantern linked a pull request May 15, 2024 that will close this issue
Open
8 tasks
@Jack-R-lantern
Copy link
Contributor

please assign me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-R-lantern Jack-R-lantern

Labels
kind/enhancement This would improve or streamline existing functionality. pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bpf: xdp replace inline asm in csum helpers Jack-R-lantern/cilium
2 participants
@julianwiedmann @Jack-R-lantern