Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete key with empty line makes Readline to return EOF #187

Open
hallazzang opened this issue Jun 9, 2020 · 2 comments
Open

Delete key with empty line makes Readline to return EOF #187

hallazzang opened this issue Jun 9, 2020 · 2 comments

Comments

@hallazzang
Copy link

Steps to reproduce problem:

  1. Input aaa
  2. Press ^A(Ctrl+A) to move cursor to the beginning of the line
  3. Press Delete key 4 times

Here's the code I used:

package main

import (
	"fmt"

	"github.com/chzyer/readline"
)

func main() {
	rl, err := readline.New("> ")
	if err != nil {
		panic(err)
	}
	defer rl.Close()

	for {
		line, err := rl.Readline()
		if err != nil {
			break
		}
		println(line)
	}
}
@BunnyBrewery
Copy link

BunnyBrewery commented Jun 20, 2020

Did you use ctrl + d to deleter characters?

https://github.com/chzyer/readline/blob/master/readline.go#L119-L123

if c.EOFPrompt == "" {
	c.EOFPrompt = "^D"
} else if c.EOFPrompt == "\n" {
	c.EOFPrompt = ""
}

As you can see, if you don't EOFPrompt field in Config structure, it will default to ^D

By the way, if you don't like how it reaches EOF with ^D, the following could be a fix:

for {
	line, err := rl.Readline()
	if err != nil {
                if err == io.EOF {
                        continue
                }
		break
	}
	println(line)
}

@jzyinq
Copy link

jzyinq commented Apr 30, 2021

@hallazzang @BunnyBrewery I have the same issue and handling io.EOF solve it partially.

In my case delete key causes the same behavior as ctrl+d.

I tried to change c.EOFPrompt through config but it didn't work. Did you found any other solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants