AIX support #175
Merged
AIX support #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for AIX operating system. - move term_solaris.go to term_nosyscall6.go. AIX like solaris doesn't provide syscall.Syscall6 and must rely on x/sys/unix in order to perform syscalls. - This patch won't work with versions prior to 1.13 because it needs some constants added by https://go-review.googlesource.com/c/go/+/171339.
derickr
reviewed
Feb 9, 2022
| @@ -2,7 +2,7 @@ | |||
| // Use of this source code is governed by a BSD-style | |||
| // license that can be found in the LICENSE file. | |||
|
|
|||
| // +build darwin dragonfly freebsd linux,!appengine netbsd openbsd solaris | |||
| // +build aix darwin dragonfly freebsd linux,!appengine netbsd openbsd solaris | |||
There was a problem hiding this comment.
Would it be possible to add os400 here as well, as well as in the other files? I'm looking at making IBMi binaries based on the toolchain from https://github.com/kadler/go/tree/pase-go1.15.3
| @@ -2,7 +2,7 @@ | |||
| // Use of this source code is governed by a BSD-style | |||
| // license that can be found in the LICENSE file. | |||
|
|
|||
| // +build solaris | |||
| // +build aix solaris | |||
| @@ -1,4 +1,4 @@ | |||
| // +build darwin dragonfly freebsd linux,!appengine netbsd openbsd solaris | |||
| // +build aix darwin dragonfly freebsd linux,!appengine netbsd openbsd solaris | |||
|
|
|||
|
please accept this pull, we need it thnaks |
|
Thanks, guys! |
|
I see you've merged this without my suggestions for |
|
@derickr oops, appreciate your help making a PR. |
derickr
added a commit
to derickr/chzyer-readline
that referenced
this pull request
Apr 18, 2022
Merged
chzyer
pushed a commit
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for AIX operating system.
move term_solaris.go to term_nosyscall6.go. AIX like solaris doesn't
provide syscall.Syscall6 and must rely on x/sys/unix in order to perform
syscalls.
This patch won't work with versions prior to 1.13 because it needs
some constants added by https://go-review.googlesource.com/c/go/+/171339.