Arbitrary 04x #849
Merged
Arbitrary 04x #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for picking this up and extending it @greyblake! As you surmised, I’m not able to spend much time on chrono right now… |
djc
approved these changes
Oct 18, 2022
|
Thanks! |
|
@djc Thank you for accepting the changes! Would you mind publishing a new version with these changes? ( |
Closed
|
@greyblake see #850. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is replacement for #848 and #559 and targets 0.4.x branch.
Changes
arbitraryoptional featureArbitraryfor the following types:NaiveDate,NaiveTime,NaiveDateTimeFixedOffset,Utc,LocalDate,Time,DateTimeDuration(oldtime)Month,MonthsWeekdayNotes
It still requires tweaking CI to run
cargo check --features arbitrary, I am not sure what would be the best place for this, so I leave it for the maintainers.P.S.
If this gets merged, would it be possible to publish a new version?