add/sub Days #784
Merged
add/sub Days #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avantgardnerio
suggested changes
Aug 17, 2022
djc
reviewed
Aug 18, 2022
esheppa
force-pushed
the
add-days-datatype
branch
from
e5d5e64
to
916a32f
Compare
djc
approved these changes
Aug 22, 2022
esheppa
force-pushed
the
add-days-datatype
branch
from
916a32f
to
3caf9f6
Compare
djc
approved these changes
Aug 22, 2022
docs fixes improve checked impls
esheppa
force-pushed
the
add-days-datatype
branch
from
5f78873
to
5721f2b
Compare
djc
approved these changes
Aug 23, 2022
|
Having thought about this a bit, I think I need to add some tests before this gets merged 😄 |
|
I've reused the tests from |
djc
approved these changes
Aug 29, 2022
|
@djc - what is the best way to get these commits into main as well - should we periodically PR |
|
Yes, I think so. |
Closed
This was referenced Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the work done by @avantgardnerio and @djc with the
Monthsdatatype but for calendarDays.This should resolve #339 and #290 and is relevant to the clarification in #100.
Potential future work could:
daysandweekshelper functions onDurationas they are somewhat misleading, directing users to useDaysinsteadsuccandpredonNaiveDate- although sometimes it's nice to have multiple ways to do somethingAdd<Duration>andSub<Duration>impls forNaiveDateThis is a bit light on documentation as I'm not sure whether this is wanted or not. If the idea here is looking good, I'll add more docs.