Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bumping MSRV to 1.34.0 for TryFrom #757

Closed
lopopolo opened this issue Aug 6, 2022 · 4 comments
Closed

Consider bumping MSRV to 1.34.0 for TryFrom #757

lopopolo opened this issue Aug 6, 2022 · 4 comments
Labels
API-incompatible Tracking changes that need incompatible API revisions
Milestone

Comments

@lopopolo
Copy link

lopopolo commented Aug 6, 2022

I think the only dependency on num-traits in chrono is in the format module which uses ToPrimitive for fallible integer casts.

This functionality is provided by core as e.g. i32::try_from(x).

I hope with the MSRV bump, the dependency on num-traits can be dropped.

@djc
Copy link
Contributor

djc commented Aug 8, 2022

We're considering bumping to 1.48 soon (unless we get feedback that people still need something older), we can eliminate the num-traits usage then, too (would be nice!).

@esheppa
Copy link
Collaborator

esheppa commented Aug 9, 2022

MSRV is now 1.38 since #756 - but I'll leave this open so that I don't forget to remove num-traits as we can now use TryFrom

@djc
Copy link
Contributor

djc commented Aug 9, 2022

Note that we cannot get rid of num-traits in 0.4.x, as it constitutes public API. We could still add TryFrom impls, of course.

@esheppa esheppa added the API-incompatible Tracking changes that need incompatible API revisions label Aug 9, 2022
@esheppa esheppa added this to the 0.5 milestone Aug 9, 2022
@pitdicker
Copy link
Collaborator

We now Have TryFrom and the MSRV is 1.56, so this issue seems completed.

@djc djc closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-incompatible Tracking changes that need incompatible API revisions
Projects
None yet
Development

No branches or pull requests

4 participants