New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::error::Error for ParseWeekdayError #745

Merged

djc merged 1 commit into main from parse-weekday-error

Jul 27, 2022

Contributor

djc commented Jul 27, 2022

Fixes #743. @EvanCarroll any thoughts?

djc requested a review from esheppa

July 27, 2022 12:31

esheppa approved these changes

View reviewed changes


          Implement std::error::Error for ParseWeekdayError

2e857d0

djc force-pushed the parse-weekday-error branch from 8e4ef1a to 2e857d0 Compare

July 27, 2022 12:50

djc merged commit 353f179 into main

djc deleted the parse-weekday-error branch

July 27, 2022 14:29

EvanCarroll commented Jul 27, 2022

Looks good to me, I didn't get a chance to confirm if it would work yet but I will today. Thanks for the insanely fast response to time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment