Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused libc dependency from Cargo.toml #710

Merged
merged 3 commits into from Jun 17, 2022
Merged

Remove unused libc dependency from Cargo.toml #710

merged 3 commits into from Jun 17, 2022

Conversation

metent
Copy link
Contributor

@metent metent commented Jun 15, 2022

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry
    about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that
    we can't reintroduce it?

libc dependency should be removed as it is no longer directly used by chrono. I'm not sure whether the changelog should document this change.

@esheppa
Copy link
Collaborator

esheppa commented Jun 16, 2022

Hi @metent - thanks for this, it looks good to me. If possible could you update the documentation about this feature here. I think its worth putting in the changelog as this could be "potentially breaking" in a weird case - because libc is an optional crate, people could add it to their chrono features. We could resolve this by adding a feature called "libc" that does nothing as specified here

@metent
Copy link
Contributor Author

metent commented Jun 16, 2022

Thanks for the pointer. Should be good now.

@esheppa
Copy link
Collaborator

esheppa commented Jun 17, 2022

Thanks @metent

@esheppa esheppa merged commit 13e1d48 into chronotope:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants