Fix parse panic #686
Merged
Fix parse panic #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
May 5, 2022
|
|
||
| // this is used to prevent an overflow when calling FixedOffset::from_local_datetime | ||
| datetime | ||
| .checked_sub_signed(OldDuration::seconds(i64::from(offset.local_minus_utc()))) |
There was a problem hiding this comment.
Sorry, now that I'm looking at this in context I'm having second thoughts. What would it take to move this check into TimeZone::from_local_datetime()? Can you check what happens to that method in #677?
There was a problem hiding this comment.
The problem I see is that TimeZone::from_local_datetime() returns a LocalResult, and I think it would be counter-intuitive if it returned LocalResult::None for that.
|
Thank you for working on this! |
botahamec
force-pushed
the
fix-parse-panic
branch
3 times, most recently
from
dfc4027
to
ce0a2d7
Compare
botahamec
force-pushed
the
fix-parse-panic
branch
from
ce0a2d7
to
bfddc1e
Compare
|
I had trouble fixing the merge conflict somehow, but it should be good now |
djc
approved these changes
Jun 8, 2022
botahamec
force-pushed
the
fix-parse-panic
branch
from
4545f9e
to
307b82e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #645. The test was previously panicking when subtracting the
FixedOffsetfrom theNaiveDateTime. There may be other places that use that subtraction that we want to look at in the future.