Update absolute path to 2018 syntax for WASM/wasmbind feature #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Do you have a suggestion how we could test this in CI? |
djc
approved these changes
Apr 8, 2022
|
The clippy failures are unrelated, but I don't have permissions to merge without the checks passing. If you have the chance, please fix them up in a separate commit, or I'll get to it soon. |
Actually, this error only occurs when both the "wasmbind" and "clock" features are enabled, for the wasm32 target. CI would need to compile for this feature combination to detect errors like this one. As for the lint errors, let me handle that shortly. |
|
Should we just silence clippy for the four trait methods it complains about? Renaming these would be breaking. |
|
Lints have been fixed on main, please rebase. |
botahamec
pushed a commit
to botahamec/chrono
that referenced
this pull request
May 26, 2022
pickfire
pushed a commit
to pickfire/chrono
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compile error where a struct path is in the 2015 format. Affected wasm32 targets with features "wasmbind" and "clock" enabled.