Fix compiling for wasm32-unknown-emscripten target #519 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error[E0428]: the name `inner` is defined multiple times --> /github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.19/src/sys.rs:25:1 | 21 | mod inner; | ---------- previous definition of the module `inner` here ... 25 | mod inner; | ^^^^^^^^^^ `inner` redefined here | = note: `inner` must be defined only once in the type namespace of this module
2 tasks
|
If wasm32-unknown-emscripten is (Nevermind the fact that I submitted a PR to fix the same problem without looking whether somebody already did. Sorry for that.) |
2 tasks
Closed
Closed
Yes it is better. Emscripten has working implementations of |
|
Ah great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a bug while compiling for the wasm32-unknown-emscripten target (https://github.com/orion78fr/godot_keepass_rust_totp/runs/2742402148?check_suite_focus=true) and it seems I wasn't the only one : #519
I don't know if you really need (and how to do) a test for this as it seems that it haven't been caught by your CI.