Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic with TZ="pBB24" #1480

Open
pitdicker opened this issue Mar 2, 2024 · 1 comment
Open

Panic with TZ="pBB24" #1480

pitdicker opened this issue Mar 2, 2024 · 1 comment

Comments

@pitdicker
Copy link
Collaborator

Gave my first try fuzzing chrono, starting with setting the TZ env variable.
It came up with "pBB24"

We accept an offset of +24 hours for a time zone named "pBB".
But in chrono we define that an offset can be at most 23:59:59, and return LocalResult::None (and then panic) when trying to do anything with Local.

@pitdicker
Copy link
Collaborator Author

The fix is to change a 24 to 23 in tz_info::rule::parse_offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant