From d0a8c00a16849a549b80ec49146f5c7db42586df Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Fri, 1 Jul 2022 01:56:59 +0000 Subject: [PATCH] testing: support python3 in headless_python_unittests.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: 1340449 Change-Id: I364fce6f0b86f0129e8f9e94de744c59dea115ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3734707 Reviewed-by: Sami Kyöstilä Reviewed-by: Brian Sheedy Commit-Queue: Sami Kyöstilä Auto-Submit: Takuto Ikuta Cr-Commit-Position: refs/heads/main@{#1019917} --- .../lib/browser/devtools_api/client_api_generator_unittest.py | 4 ++-- testing/scripts/headless_python_unittests.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/headless/lib/browser/devtools_api/client_api_generator_unittest.py b/headless/lib/browser/devtools_api/client_api_generator_unittest.py index 9e1ca65684025..cd49df0209c5d 100755 --- a/headless/lib/browser/devtools_api/client_api_generator_unittest.py +++ b/headless/lib/browser/devtools_api/client_api_generator_unittest.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright 2016 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be @@ -15,7 +15,7 @@ class ClientApiGeneratorTest(unittest.TestCase): def test_ArgumentParsing(self): with tempfile.NamedTemporaryFile() as f: - f.write('{"foo": true}') + f.write(b'{"foo": true}') f.flush() json_api, output_dir = client_api_generator.ParseArguments([ '--protocol', f.name, '--output_dir', 'out']) diff --git a/testing/scripts/headless_python_unittests.py b/testing/scripts/headless_python_unittests.py index 4e32907528efe..cb0bb375681a6 100755 --- a/testing/scripts/headless_python_unittests.py +++ b/testing/scripts/headless_python_unittests.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env vpython3 # Copyright 2016 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -38,7 +38,7 @@ def main_run(args): valid = bool(rc <= common.MAX_FAILURES_EXIT_STATUS and ((rc == 0) or failures)) common.record_local_script_results( - 'headless_python_unittests', args.output, failures.keys(), valid) + 'headless_python_unittests', args.output, list(failures.keys()), valid) return rc