Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

here always need 5 ms #928

Closed
mlboy opened this issue Oct 18, 2021 · 1 comment · Fixed by #929
Closed

here always need 5 ms #928

mlboy opened this issue Oct 18, 2021 · 1 comment · Fixed by #929

Comments

@mlboy
Copy link

mlboy commented Oct 18, 2021

chromedp/query.go

Line 162 in 3f81ff8

case <-time.After(5 * time.Millisecond):

It's not necessary in first time
ZekeLu added a commit to ZekeLu/chromedp that referenced this issue Oct 18, 2021
@ZekeLu
avoid the unnecessary wait in the first iteration of a loop
6a0692e 
fixes chromedp#928
@ZekeLu ZekeLu mentioned this issue Oct 18, 2021
Merged
@ZekeLu
Copy link
Member

ZekeLu commented Oct 18, 2021

@mlboy Good catch! Thanks!

I have just sent #929 to fix that. But the fix looks a little ugly.

ZekeLu added a commit to ZekeLu/chromedp that referenced this issue Oct 18, 2021
@ZekeLu
avoid the unnecessary wait in the first iteration of a loop
407718d 
fixes chromedp#928
@ZekeLu ZekeLu changed the title here aways need 5 ms here always need 5 ms Oct 18, 2021
ZekeLu added a commit that referenced this issue Dec 7, 2021
@ZekeLu
avoid the unnecessary wait in the first iteration of a loop
875d6f4 
fixes #928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid the unnecessary wait in the first iteration of a loop ZekeLu/chromedp
2 participants
@ZekeLu @mlboy