Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child process not reaped #894

Closed
takakawa opened this issue Aug 4, 2021 · 2 comments
Closed

child process not reaped #894

takakawa opened this issue Aug 4, 2021 · 2 comments

Comments

@takakawa
Copy link

takakawa commented Aug 4, 2021

when running in docker after a while, there are many many process left defunct

image

@ZekeLu
Copy link
Member

ZekeLu commented Aug 4, 2021

see #752

You can do two things to make it better:

  1. specify the init process to reap the zombie processes: https://docs.docker.com/engine/reference/run/#specify-an-init-process
  2. try to use a single browser instance and create new tabs in it (instead of creating many browser instances)

chromedp/chromedp_test.go

Lines 112 to 113 in 40faabd

// Same browser, new tab; not needing to start new chrome browsers for
// each test gives a huge speed-up.

@ZekeLu
Copy link
Member

ZekeLu commented Oct 16, 2021

Closing as a duplicate of #752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants