make the screenshot actions act the same as Chrome commands #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2021
Closed
Before this change, it's relative to the viewport. So it will get the wrong position if the page scrolls. Fixes chromedp#844.
Here is the list of actions and the coresponding commands: - FullScreenshot: Capture full size screenshot - CaptureScreenshot: Capture screenshot - Screenshot: Capture node screenshot
Reasons: - CaptureScreenshot has nothing to do with navigation, so it's ok to move it out of the nav.go file. - FullScreenshot does not use emulate action any more, so it's ok to move it out of the emulate.go file. - query.go is a little big and I'm planning to add more unit test for the screenshot feature, so it's better to move the feature to another file. This change is a simple refactor, and does not change any behavior of the source code.
github.com/orisano/pixelmatch is a go port of pixelmatch, which is used by puppeteer to compare images.
This unit test is copied from puppeteer: - testdata/grid.html - testdata/digits/[0-9].png - testdata/screenshots/grid-fullpage.png
This unit test is copied from puppeteer: - testdata/screenshots/sanity.png
This unit test is copied from puppeteer. The Screenshot action is updated to handle fractional dimensions properly too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues by making the screenshot actions act the same as the family of capture screenshot commands provided by Chrome. And it copies some of the unit tests from https://github.com/puppeteer/puppeteer/ too.
Here is the details:
captureBeyondViewport: true, fixes Blank image in non-headless mode for fullscreen screenshot #859)Note: this PR uses
CallFunctionOnand, so it can not be merged until #852 is merged. I will change the state to//go:embedDraft.Update: The
//go:embedchanges has been removed so that we can release this PR first.